Implement change_table_comment and change_column_comment #30677
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kamipo (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
| @@ -365,6 +370,12 @@ def change_column_null(table_name, column_name, null, default = nil) #:nodoc: | |||
| change_column table_name, column_name, column.sql_type, null: null | |||
| end | |||
|
|
|||
| # Adds comment for given table column or drops it if +comment+ is a +nil+ | |||
| def change_column_comment(table_name, column_name, comment) | |||
| @@ -311,6 +311,11 @@ def bulk_change_table(table_name, operations) #:nodoc: | |||
| execute("ALTER TABLE #{quote_table_name(table_name)} #{sqls}") | |||
| end | |||
|
|
|||
| # Adds comment for given table or drops it if +comment+ is a +nil+ | |||
| def change_table_comment(table_name, comment) | |||
|
Sure, I'll add the test for update to nil. |
|
Can you squash your commits into 1 please? |
|
Done. Thank you for your review. |
|
Thanks! |
Implemented by rails#22911 Related to rails#30677
Implement change_table_comment and change_column_comment for MySql.
The two methods were defined in PR #22911 but only implemented for PostgreSQL.